Skip to content

[Core] Remove publish token validation #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2020
Merged

[Core] Remove publish token validation #2123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be53d88
Remove publish token validation
Sep 15, 2020
93b16f2
Update changelog
Sep 15, 2020
b0ec951
Add revapi exception
Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

### Fixed

* [Core] Validation of `CUCUMBER_PUBLISH_TOKEN` no longer happens inside Cucumber-JVM - only on the server.
([2123](https://github.com/cucumber/cucumber-jvm/pull/2123)
[2122](https://github.com/cucumber/cucumber-jvm/issues/2122)
Aslak Hellesøy)

## [6.7.0] (2020-09-14)

### Added
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/io/cucumber/core/options/CucumberPropertiesParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public RuntimeOptionsBuilder parse(Map<String, String> properties) {

parse(properties,
PLUGIN_PUBLISH_TOKEN_PROPERTY_NAME,
PublishTokenParser::parse,
s -> s, // No validation - validated on server
builder::setPublishToken);

parse(properties,
Expand Down
20 changes: 0 additions & 20 deletions core/src/main/java/io/cucumber/core/options/PublishTokenParser.java
View file
Open in desktop

This file was deleted.

31 changes: 0 additions & 31 deletions core/src/test/java/io/cucumber/core/options/PublishTokenParserTest.java
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions ...latform-engine/src/main/java/io/cucumber/junit/platform/engine/CucumberEngineOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import io.cucumber.core.feature.GluePath;
import io.cucumber.core.options.ObjectFactoryParser;
import io.cucumber.core.options.PluginOption;
import io.cucumber.core.options.PublishTokenParser;
import io.cucumber.core.options.SnippetTypeParser;
import io.cucumber.core.plugin.NoPublishFormatter;
import io.cucumber.core.plugin.PublishFormatter;
Expand Down Expand Up @@ -90,7 +89,6 @@ private Optional<PluginOption> getPublishQuitePlugin() {
private Optional<PluginOption> getPublishTokenPlugin() {
return configurationParameters
.get(PLUGIN_PUBLISH_TOKEN_PROPERTY_NAME)
.map(PublishTokenParser::parse)
.map(token -> PluginOption.forClass(PublishFormatter.class, token));
}

Expand Down
5 changes: 5 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,6 +655,11 @@
<justification>https://github.com/cucumber/cucumber-jvm/pull/2099</justification>
<newValue>https://messages.cucumber.io/api/reports -X GET</newValue>
</item>
<item>
<code>java.class.removed</code>
<old>class io.cucumber.core.options.PublishTokenParser</old>
<justification>Internal API</justification>
</item>
</revapi.ignore>
</analysisConfiguration>
</configuration>
Expand Down