[Compatibility] Fix platform dependent tests #2148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 8, 2020 23:52
… only works if the repository was cloned with symlinks activated and windows being in developer mode.
… ensures that the generated sources with UTF-8 filenames like Når.java are correctly handled by maven, when running on operating system with another default encoding (e.g. windows)
…y fail. The default configuration of git on windows is to let git do end-of-line conversion, i.e. converting between LF in the repository and CRLF in the working tree. If this happens on the feature files in this directory, tests fail, because the test will read the feature file (with crlf line endings) and compare it to the files describing the expected outcome (containing only lf).
mpkorstanje
changed the title
mpkorstanje
changed the title
mpkorstanje
reviewed
Oct 10, 2020
| @@ -0,0 +1 @@ | |||
| -Dfile.encoding=UTF-8 | |||
mpkorstanje
reviewed
Oct 10, 2020
| @@ -0,0 +1,3 @@ | |||
| # Ensure that LF line endings are kept on checkout (even on windows). Tests will fail otherwise | |||
| *.ndjson text eol=lf | |||
| *.feature text eol=lf | |||
|
Thanks again. Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your pull request related to a problem? Please describe.
This should fix all remaining problems with building under windows #2104
Describe the solution you have implemented
To make build work out of the box on windows the following two changes were done: