Skip to content

[Compatibility] Fix platform dependent tests #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2020
Merged

[Compatibility] Fix platform dependent tests #2148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3584b84
Disabled scanForResourcesDirectorySymlink test on windows, because it…
Oct 8, 2020
878087e
Add config to ensure that maven runs with -Dfile.encoding=UTF-8. This…
Oct 8, 2020
8037a6c
Ensure that line endings do not get altered by git, otherwise test ma…
Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .mvn/jvm.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
-Dfile.encoding=UTF-8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty neat!

3 changes: 3 additions & 0 deletions compatibility/src/test/resources/.gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Ensure that LF line endings are kept on checkout (even on windows). Tests will fail otherwise
*.ndjson text eol=lf
*.feature text eol=lf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

5 changes: 4 additions & 1 deletion core/src/test/java/io/cucumber/core/resource/ResourceScannerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ void scanForResourcesPath() {

@Test
@DisabledOnOs(value = OS.WINDOWS,
disabledReason = "Only works if repository is explictly cloned activated symlinks and " +
disabledReason = "Only works if repository is explicitly cloned activated symlinks and " +
"developer mode in windows is activated")
void scanForResourcesPathSymlink() {
File file = new File("src/test/resource-symlink/test/resource.txt");
Expand All @@ -125,6 +125,9 @@ void scanForResourcesDirectory() {
}

@Test
@DisabledOnOs(value = OS.WINDOWS,
disabledReason = "Only works if repository is explicitly cloned activated symlinks and " +
"developer mode in windows is activated")
void scanForResourcesDirectorySymlink() {
File file = new File("src/test/resource-symlink");
List<URI> resources = resourceScanner.scanForResourcesPath(file.toPath());
Expand Down