Prevent duplicate glue paths #632
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to #608 |
|
@martykube |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When RuntimeOptionsFactory builds RuntimeOptions if the target class is a member of a class hierarchy contained in one package the glue path with have multiple entries for the containing package. This will then cause a "duplicate step definition" error during duplicated scans of the glue path (see #622).
This pull request aims to eliminate duplicate glue paths by changing the type of RuntimeOptions.glue from a list to a set. This will enforce uniqueness, always.
The main change is RuntimeOptions.glue. The remaining changes are to update the signature of Backend.loadGlue() to accept a set (instead of a list) of glue paths.