The RuntimeOptionsFactory should add default feature path, glue path and formatter once #636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #568 and the change from @Cucumber.options to @CucumberOptions, the following runner structure:
resulted in that the RuntimeOptions contains:
(one reason to have a runner base class could be to have @BeforeClass and @afterclass annotated methods there)
Since #568 is about using parameters from @CucumberOptions annotation from all levels of the runner inheritance hierarchy, there is no reason that the behavior when not using any @CucumberOptions annotations should not remain the same.
However, currently default feature path and default glue path are added once for each inheritance level where they are not explicitly defined (regardless whether a @CucumberOptions annotation exist on that level or not). And currently default formatter is added once for each inheritance level where the is an @CucumberOptions annotation which does not define formatters explicitly). The result is that the above runner structure result in a RuntimeOptions containing:
This PR reverts the RuntimeOptionsFactory behavior back to the original one regarding adding default feature paths, glue paths and formatters.
With this change the unique glue path work around in the TestNGCucumberRunner can be removed, and thus is neither #632 or #633 needed for that reason.