Skip to content

Fixes #1964. Split matching_map_A01_t01.dart into two tests. The second one is for sound nullability only #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

sgrekhov
Copy link
Contributor

No description provided.

… The second one is for sound nullability only
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(There will be a need to adjust these because they use {...} as a map pattern, but I assume that's in another PR).

@eernstg eernstg merged commit 7edd464 into dart-lang:master Mar 30, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 31, 2023
2023-03-30 [email protected] Fixes dart-lang/co19#1964. Split matching_map_A01_t01.dart into two tests. The second one is for sound nullability only (dart-lang/co19#1965)
2023-03-30 [email protected] dart-lang/co19#1401. If- and for-elements tests for maps and sets added (dart-lang/co19#1967)
2023-03-30 [email protected] Remove ProcessInfo constructor test (dart-lang/co19#1975)
2023-03-29 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.10.0 to 3.11.0 (dart-lang/co19#1971)
2023-03-29 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.3.0 to 3.5.0 (dart-lang/co19#1970)
2023-03-28 [email protected] Fixes dart-lang/co19#1972. Add nnbd-strong flag to some map-pattern runtime tests (dart-lang/co19#1973)
2023-03-27 [email protected] Fix IntPtrArray_A01_t01.dart. Remove platform-depended code (dart-lang/co19#1969)

Change-Id: I23b05e414ef7517ee198e426fbf9b85165ce89b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292300
Reviewed-by: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov deleted the co19-1964 branch July 18, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants