Fix IntPtrArray_A01_t01.dart. Remove platform-depended code #1969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcharkes
approved these changes
Mar 27, 2023
| array[i] = -32769; | ||
| Expect.equals(32767, array[i]); | ||
| } else { | ||
| array[i] = 32768; |
There was a problem hiding this comment.
You can keep these lines, they should succeed, all the values are with 32 bits.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 31, 2023
2023-03-30 [email protected] Fixes dart-lang/co19#1964. Split matching_map_A01_t01.dart into two tests. The second one is for sound nullability only (dart-lang/co19#1965) 2023-03-30 [email protected] dart-lang/co19#1401. If- and for-elements tests for maps and sets added (dart-lang/co19#1967) 2023-03-30 [email protected] Remove ProcessInfo constructor test (dart-lang/co19#1975) 2023-03-29 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.10.0 to 3.11.0 (dart-lang/co19#1971) 2023-03-29 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.3.0 to 3.5.0 (dart-lang/co19#1970) 2023-03-28 [email protected] Fixes dart-lang/co19#1972. Add nnbd-strong flag to some map-pattern runtime tests (dart-lang/co19#1973) 2023-03-27 [email protected] Fix IntPtrArray_A01_t01.dart. Remove platform-depended code (dart-lang/co19#1969) Change-Id: I23b05e414ef7517ee198e426fbf9b85165ce89b5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292300 Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.