You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Re-enable skipped ChromeProxyService test cases
Note: some tests are failing due to different code in sound fixtures, ie Classes (MyTestClass has different fields, update to match)
Migrate the events_test to null-safety (somehow it was missed in the null-safety migration)
Run all tests (where applicable) in both weak and sound null-safety modes. Most of our tests were using the weak null-safety test fixtures, which is what caused the failures.
Re-enable disabled test in reload_test. The callback passed to registerExtension requires a non-null return type [1].
[FINEST] ExpressionCompilerService: Failed to compile "() => registerExtension('ext.foo', (method, params) {})": org-dartlang-debug:synthetic_debug_expression:1:36: Error: A non-null value must be returned since the return type 'Future<ServiceExtensionResponse>' doesn't allow null.
- 'Future' is from 'dart:async'.
- 'ServiceExtensionResponse' is from 'dart:developer'.
() => registerExtension('ext.foo', (method, params) {}) ^
The text was updated successfully, but these errors were encountered:
This issue tracks the work involved to fix all the tests so that they are compatible with both version
3.0.0
and older versions.Work involved:
3.0.0
#1817TestContext
constructor for clarity #1844ChromeProxyService
test casesNote: some tests are failing due to different code in sound fixtures, ie
Classes
(MyTestClass
has different fields, update to match)events_test
to null-safety (somehow it was missed in the null-safety migration)events_test.dart
to null-safety #1819reload_test
. The callback passed to registerExtension requires a non-null return type [1].frontend_server_asset_reader_tests
dart_uri_file_uri_test
can be for sound null-safety only.The text was updated successfully, but these errors were encountered: