Enable weak tests for build daemon and frontend server #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrin
commented
Dec 14, 2022
| @@ -9,12 +9,12 @@ description: >- | |||
| publish_to: none | |||
|
|
|||
| environment: | |||
| sdk: ">=2.5.0 <3.0.0" | |||
| sdk: ">=2.18.0 <3.0.0" | |||
There was a problem hiding this comment.
Basically this is what makes the weak tests work. Filed an issue to investigate why this constraint solves at all: https://github.com/dart-lang/sdk/issues/50717
There was a problem hiding this comment.
Apparently it is a feature (reply from the issue above) so the solution is confirmed:
(I believe <3.0.0 is treated the same as <4.0.0 when the lower bound is >= 2.12.0 (dart-lang/pana@9882d0e).
The cause of this resolution failure is because a lower bound below 2.12, in this case >=2.10.0, means that package does not support null safety which is required by Dart 3. See dart-lang/pub#3686 for more context on the resolution message.
annagrin
commented
Dec 14, 2022
annagrin
changed the title
elliette
approved these changes
Dec 14, 2022
elliette
changed the title
This was referenced Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.