[MV3 Debug Extension] The new debug extension can be run on Manifest V3 or Manifest V2 #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrin
reviewed
Feb 16, 2023
elliette
added a commit
to elliette/webdev
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #1950
Allows us to build the extension with Manifest V2:
dart run tool/build_extension.dartOr with Manifest V3:
dart run tool/build_extension.dart --mv3The Puppeteer tests have also been updated to test on both Manifest V2 and Manifest V3.
NOTE: Make sure to "hide whitespace" in diff settings when reviewing, otherwise the changes to
extension_testlook overwhelming!