Drop Python 3.9; test on Python 3.13; drop NumPy 1.21; skip CUDA install #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
commented
Apr 10, 2025
| @@ -100,8 +95,6 @@ version. | |||
| - As with NumPy, type annotations and positional-only arguments may not | |||
| exactly match the spec for functions that are not wrapped at all. | |||
|
|
|||
| The minimum supported PyTorch version is 1.13. | |||
There was a problem hiding this comment.
Do not advertise what you don't test.
crusaderky
commented
Apr 10, 2025
| @@ -131,8 +124,6 @@ For `linalg`, several methods are missing, for example: | |||
| - `matrix_rank` | |||
| Other methods may only be partially implemented or return incorrect results at times. | |||
|
|
|||
| The minimum supported Dask version is 2023.12.0. | |||
There was a problem hiding this comment.
Do not advertise what you don't test. Also helplessly obsolete; we know for sure that less than 2024.9.0 won't work.
crusaderky
commented
Apr 10, 2025
| @@ -24,11 +23,14 @@ classifiers = [ | |||
|
|
|||
| [project.optional-dependencies] | |||
| cupy = ["cupy"] | |||
| dask = ["dask"] | |||
| dask = ["dask>=2024.9.0"] | |||
There was a problem hiding this comment.
It may be a good idea to completely remove all mentions of minimum versions until we have unit tests in place for them (i.e. not anytime soon).
crusaderky
commented
Apr 10, 2025
| numpy = ["numpy"] | ||
| # Note: array-api-compat follows scikit-learn minimum dependencies, which support | ||
| # much older versions of NumPy than what SPEC0 recommends. | ||
| numpy = ["numpy>=1.22"] | ||
| pytorch = ["torch"] | ||
| sparse = ["sparse>=0.15.1"] |
crusaderky
commented
Apr 10, 2025
numpy-1-22-xfails.txt
Outdated
| # attributes are np.float32 instead of float | ||
| # (see also https://github.com/data-apis/array-api/issues/405) | ||
| array_api_tests/test_data_type_functions.py::test_finfo[float32] | ||
| array_api_tests/test_data_type_functions.py::test_finfo[complex64] | ||
|
|
||
| # Rounding error near infinity | ||
| array_api_tests/test_operators_and_elementwise_functions.py::test_clip |
There was a problem hiding this comment.
This seems to crop up only when the test is run on its own
There was a problem hiding this comment.
crusaderky
commented
Apr 10, 2025
| array_api_tests/test_operators_and_elementwise_functions.py::test_remainder[__imod__(x1, x2)] | ||
| array_api_tests/test_operators_and_elementwise_functions.py::test_remainder[__mod__(x, s)] | ||
| array_api_tests/test_operators_and_elementwise_functions.py::test_remainder[__mod__(x1, x2)] | ||
| array_api_tests/test_operators_and_elementwise_functions.py::test_remainder[remainder(x1, x2)] |
There was a problem hiding this comment.
Tested these and could reproduce none of the core dumps
crusaderky
commented
Apr 10, 2025
| array_api_tests/test_operators_and_elementwise_functions.py::test_remainder[__imod__(x1, x2)] | ||
| array_api_tests/test_operators_and_elementwise_functions.py::test_remainder[__mod__(x, s)] | ||
| array_api_tests/test_operators_and_elementwise_functions.py::test_remainder[__mod__(x1, x2)] | ||
| array_api_tests/test_operators_and_elementwise_functions.py::test_remainder[remainder(x1, x2)] |
There was a problem hiding this comment.
Could reproduce none of these
crusaderky
changed the title
|
@ev-br ready for review |
This reverts commit 3bc8ffa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #266
scikit-learnminimumscikit-learn(closes Drop Python 3.9 #230)--max-examples 100000on NumPy 1.22--max-examples 1000on all other numpy versions