test_clip: make sure min and max have the same dtype as x
#360
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the spec: 'should have the same dtype as x'
|
Run tests with |
|
Tested the branch (running with 2_000 examples) locally and can verify that it resolves gh-359 for dpctl.tensor |
This was referenced Apr 10, 2025
oleksandr-pavlyk
approved these changes
Apr 10, 2025
Definitely the spec should clarify that int scalars should be cast to float. |
crusaderky
reviewed
Apr 11, 2025
| @@ -987,17 +987,15 @@ def test_clip(x, data): | |||
| base_shape=x.shape), | |||
| label="min.shape, max.shape") | |||
|
|
|||
| dtypes = hh.real_floating_dtypes if dh.is_float_dtype(x.dtype) else hh.int_dtypes | |||
|
|
|||
| min = data.draw(st.one_of( | |||
| st.none(), | |||
| hh.scalars(dtypes=st.just(x.dtype)), | |||
There was a problem hiding this comment.
note: this misses out on the use case clip(Array[float], int)
#364
crusaderky
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes gh-359, closes gh-339
Per the spec: 'should have the same dtype as x': https://data-apis.org/array-api/latest/API_specification/generated/array_api.clip.html
The spec is not very clear on whether
minandmaxcan beintscalars for a real-valuedxarray, should probably clarify in the spec: