✅ test: add tests & CI #18
Conversation
jorenham
added
✅ tests
.github/workflows/ci.yml
Outdated
|
|
||
| - name: Install the project | ||
| run: uv sync --group test |
There was a problem hiding this comment.
I don't think that --group plays well with caching, because we use different groups in different jobs with the same cache key. Uv is already insanely fast, so I don't expect that using different cache keys will help much in practice. So I suppose we could just install everything, and skip this step altogether.
| - name: Install the project | |
| run: uv sync --group test |
There was a problem hiding this comment.
I don't think pytest will be installed though...
| env: | ||
| # Many color libraries just need this to be set to any value, but at least | ||
| # one distinguishes color depth, where "3" -> "256-bit color". | ||
| FORCE_COLOR: 3 |
There was a problem hiding this comment.
Hmm I haven't seen this one before 🤔. What problem does this solve?
There was a problem hiding this comment.
This is included automatically by https://github.com/scientific-python/cookie IIRC
There was a problem hiding this comment.
I'm guessing that scientific-python/cookie#405 is the reason for it then, which links to https://force-color.org/:
By adopting this standard, users who want colored text output, even in situations like piping or CI environments can simply export
FORCE_COLOR=1to their environment. This will automatically enable color by default in all software that follows the standard.
And here's the explanation for why 3 is used, and not 1:
One library that I know of (one I wrote years ago, to be fair) -
plumbum.colors- takes levels for FORCE_COLOR, with 1 being 8-color, 2 being 16-color, 3 being 256 color, and 4 being true color, based on the four ways to do ANSI codes. I've always hoped other libraries would pick up on that, so I've always set it to 3. As far as I know, most other libraries just care if it's either defend or set to any value.
I mean, it's pretty interesting. Maybe it's just me (e.g. because I'm colorblind, or because it's almost 4 a.m. here), but I still don't see what problem this solves 😛.
There was a problem hiding this comment.
I actually don't know either. I've always included it, so don't know what the output looks like when removed...
| check_oldest: | ||
| name: Check Oldest Dependencies | ||
| runs-on: ${{ matrix.runs-on }} | ||
| needs: [format] |
There was a problem hiding this comment.
This might slow down the CI runs a bit.
There was a problem hiding this comment.
A little. Depends how fast the pre-commit check is.
nstarman
force-pushed
the
tests
branch
3 times, most recently
from
542d303 to
be6ff4e
Compare
|
I'd like to figure out how to get the CI going to test the suggested changes to the CI! (I know the current setup works) |
Signed-off-by: Nathaniel Starkman <[email protected]>
nstarman
force-pushed
the
tests
branch
2 times, most recently
from
6c9a852 to
20159bb
Compare
tests/test_namespace.py
Outdated
There was a problem hiding this comment.
I don't love this test. xpt.HasArrayNamespace is final and not runtime-checkable. This is a bit of a hack.
nstarman
force-pushed
the
tests
branch
5 times, most recently
from
b84a599 to
a569ad9
Compare
Co-authored-by: Joren Hammudoglu <[email protected]> Signed-off-by: Nathaniel Starkman <[email protected]>
Requires #17