PR: Add meshgrid #145
Merged
PR: Add meshgrid #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
reviewed
Mar 20, 2021
There was a problem hiding this comment.
I'm thinking that it may not be obvious enough what this function does exactly. There's many functions where we don't have extensive notes, but in this case it seems justified to add the pseudo-code for indexing (like in the Notes section of the numpy.meshgrid docstring).
kgryte
requested changes
Apr 12, 2021
There was a problem hiding this comment.
@steff456 Thanks for working on this! In my review, I mainly suggested changes to ensure consistency with the rest of spec (formatting, language, etc). I also propose consolidating some of the notes and special cases into the parameter and return value descriptions directly. Let me know if you have any questions!
kgryte
requested changes
Apr 19, 2021
kgryte
reviewed
Apr 19, 2021
kgryte
reviewed
Apr 19, 2021
kgryte
reviewed
Apr 19, 2021
kgryte
reviewed
Apr 19, 2021
rgommers
reviewed
Apr 19, 2021
kgryte
reviewed
Apr 19, 2021
rgommers
force-pushed
the
main
branch
3 times, most recently
from
0607525 to
138e963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
meshgrid, which returns coordinate matrices from coordinate vectors.Notes
copyandsparsecurrently supported in NumPy, CuPy and JAX were dropped (https://github.com/data-apis/array-api-comparison/blob/main/signatures/creation/meshgrid.md)indexingis based in the current implementation of NumPy including it's special cases for 0-D and 1-D arrays.