Skip to content

docs: fix indexing kwarg typing in meshgrid #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2025
Merged

docs: fix indexing kwarg typing in meshgrid #915

merged 2 commits into from
Apr 3, 2025

Conversation

crusaderky
Copy link
Contributor

No description provided.

@crusaderky crusaderky mentioned this pull request Mar 21, 2025
Merged
@crusaderky crusaderky changed the title meshgrid xy parameter should be literal meshgrid indexing parameter should be literal Mar 21, 2025
@kgryte
Copy link
Contributor

kgryte commented Mar 21, 2025

I believe this change may need to be backported to prior revisions of the standard.

@crusaderky
Copy link
Contributor Author

I believe this change may need to be backported to prior revisions of the standard.

Is this because it only affects static type checkers, which are uncapable of distinguishing between versions?
I've updated the prior versions too.

lucascolley
lucascolley approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Guido!

@lucascolley lucascolley added topic: Static Typing Static typing. Maintenance Bug fix, typo fix, or general maintenance. labels Mar 31, 2025
@lucascolley lucascolley added this to the v2025 milestone Mar 31, 2025
@kgryte
Copy link
Contributor

kgryte commented Apr 3, 2025

Is this because it only affects static type checkers, which are uncapable of distinguishing between versions?

No, it was just likely a typing oversight due originally adding meshgrid to the specification when it was written in Markdown (ref: #145).

kgryte
kgryte approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @crusaderky!

@kgryte kgryte changed the title meshgrid indexing parameter should be literal docs: fix indexing kwarg typing in meshgrid Apr 3, 2025
@kgryte kgryte added the Backport Changes involve backporting to previous versions. label Apr 3, 2025
@kgryte kgryte merged commit 0941b21 into data-apis:main Apr 3, 2025
3 checks passed
@crusaderky crusaderky deleted the meshgrid branch April 3, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@lucascolley lucascolley lucascolley approved these changes

Assignees
No one assigned
Labels
Backport Changes involve backporting to previous versions. Maintenance Bug fix, typo fix, or general maintenance. topic: Static Typing Static typing.
Projects
None yet
Milestone
v2025
Development

Successfully merging this pull request may close these issues.
3 participants
@crusaderky @kgryte @lucascolley