Skip to content

fix: enable multiline for navigation-items links but not buttons #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

fix: enable multiline for navigation-items links but not buttons #4065

wants to merge 12 commits into from

Conversation

michaelmkraus
Copy link
Contributor

@michaelmkraus michaelmkraus commented Apr 16, 2025 •
edited by mfranzke
Loading

Proposed changes

  • enable multiline for navigation-items that are links and not buttons

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@github-actions github-actions bot added 🧱components Changes inside components folder 📺showcases Changes to 1-n showcases labels Apr 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-navigation-items-no-button

@michaelmkraus michaelmkraus marked this pull request as ready for review April 16, 2025 14:32
@mfranzke mfranzke changed the title fix: enable multiline for navigation-items that are links and not but… fix: enable multiline for navigation-items links but not buttons Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke Awaiting requested review from mfranzke mfranzke is a code owner

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🧱components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelmkraus @nmerget