Skip to content

fix: enable multiline for navigation-items links but not buttons #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

fix: enable multiline for navigation-items links but not buttons #4065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ad512a7
fix: enable multiline for navigation-items that are links and not but…
michaelmkraus Apr 16, 2025
5e77a82
fix: adapted angular and vue showcases
michaelmkraus Apr 16, 2025
315dc2a
test: updated snapshots
michaelmkraus Apr 16, 2025
89f8045
test: updated snapshots
michaelmkraus Apr 16, 2025
71ac9db
Merge branch 'main' into fix-navigation-items-no-button
michaelmkraus Apr 16, 2025
c4f51ad
fix: adapted react showcases
michaelmkraus Apr 16, 2025
b818572
test: updated snapshots
michaelmkraus Apr 16, 2025
5b01eea
test: updated snapshots
michaelmkraus Apr 16, 2025
428858f
Merge branch 'main' into fix-navigation-items-no-button
nmerget Apr 17, 2025
ef61976
Merge branch 'main' into fix-navigation-items-no-button
michaelmkraus Apr 17, 2025
c890c5d
Merge branch 'main' into fix-navigation-items-no-button
michaelmkraus Apr 17, 2025
94392ba
Merge branch 'main' into fix-navigation-items-no-button
michaelmkraus Apr 22, 2025
80fb1f7
chore: update from main
nmerget May 5, 2025
55b181e
Merge remote-tracking branch 'origin/main' into fix-navigation-items-…
nmerget May 5, 2025
f81d4af
chore: update snapshots
nmerget May 5, 2025
9af15e1
chore: update snapshots
nmerget May 5, 2025
5252d9b
Merge remote-tracking branch 'origin/fix-navigation-items-no-button' …
nmerget May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...-chrome/DBHeader-should-match-screenshot-1/DBHeader-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 2 additions & 5 deletions ...mobile-chrome/should-have-same-aria-snapshot/DBHeader-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@
- link "Examples arrow_up_right\" / \""
- text: brand" / " DBHeader
- button "menu\" / \" BurgerMenu"
- text: brand" / " DBHeader
- button "menu\" / \" BurgerMenu"
- text: brand" / "
- text: brand" / " DBHeader brand" / "
- button "menu\" / \" BurgerMenu"
- text: brand" / "
- button "menu\" / \" BurgerMenu"
- text: brand" / "
7 changes: 2 additions & 5 deletions ...mobile-safari/should-have-same-aria-snapshot/DBHeader-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@
- link "Examples arrow_up_right\" / \""
- text: brand" / " DBHeader
- button "menu\" / \" BurgerMenu"
- text: brand" / " DBHeader
- button "menu\" / \" BurgerMenu"
- text: brand" / "
- text: brand" / " DBHeader brand" / "
- button "menu\" / \" BurgerMenu"
- text: brand" / "
- button "menu\" / \" BurgerMenu"
- text: brand" / "
13 changes: 13 additions & 0 deletions packages/components/src/components/header/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,19 @@
display: none;
}
}

// Hide the burger menu if there is no navigation
&:has(.db-header-navigation:empty) {
.db-header-burger-menu-container {
display: none;
}

&:has(.db-header-secondary-action:empty) {
.db-header-action-container::before {
display: none;
}
}
}
}

.db-header-navigation-bar {
Expand Down
8 changes: 4 additions & 4 deletions packages/foundations/docs/BrowserSupport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ We're [testing our components with playwright](../../foundations/test-table) on

This may leave some older browser versions behind. If you need to take care of these older browsers, you may not want to migrate to DB UX Design System v3 right now, but stay with DB UI Core or Elements for a little longer. In particular, the following features we use may be related to an evaluation of your browser strategy:

| Web Feature | Google Chrome | Mozilla Firefox | Apple Safari |
| ------------------------------------------------------------------------------------------------------------------------------- | ---------------- | ---------------- | ----------------- |
| [`@property` / typed CSS Custom Properties](https://developer.mozilla.org/en-US/docs/Web/CSS/@property) | 85 (25.08.2022) | 128 (09.07.2024) | 16.4 (27.03.2023) |
| [`light-dark()`](https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark) | 123 (19.03.2024) | 120 (21.11.2023) | 17.5 (13.05.2024) |
| Web Feature | Google Chrome | Mozilla Firefox | Apple Safari |
| ------------------------------------------------------------------------------------------------------- | ---------------- | ---------------- | ----------------- |
| [`@property` / typed CSS Custom Properties](https://developer.mozilla.org/en-US/docs/Web/CSS/@property) | 85 (25.08.2022) | 128 (09.07.2024) | 16.4 (27.03.2023) |
| [`light-dark()`](https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark) | 123 (19.03.2024) | 120 (21.11.2023) | 17.5 (13.05.2024) |
9 changes: 3 additions & 6 deletions packages/foundations/scss/defaults/_default-variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,14 +347,11 @@
--db-border-radius-3xl: 2rem;
--db-border-radius-full: 500rem;
--db-elevation-sm:
0 0 1px -1px #0003, 0 0 4px 1px #0000001f,
0 0 2px #00000024;
0 0 1px -1px #0003, 0 0 4px 1px #0000001f, 0 0 2px #00000024;
--db-elevation-md:
0 0 2px -1px #0003, 0 0 8px 1px #0000001f,
0 0 4px #00000024;
0 0 2px -1px #0003, 0 0 8px 1px #0000001f, 0 0 4px #00000024;
--db-elevation-lg:
0 0 4px -3px #0003, 0 0 16px 3px #0000001f,
0 0 8px 1px #00000024;
0 0 4px -3px #0003, 0 0 16px 3px #0000001f, 0 0 8px 1px #00000024;
--db-font-family-sans: "OpenSans", helvetica, arial, sans-serif;
--db-font-family-head: "OpenSans Head", helvetica, arial, sans-serif;
--db-sizing-fixed-mobile-header: 3.5rem;
Expand Down
Loading