-
Notifications
You must be signed in to change notification settings - Fork 10
feat: change color of label on hovered and active state #4077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/feat-optimize-hover-data-inputs |
… into feat-optimize-hover-data-inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- packages/components/src/styles/internal/_form-components.scss: Language not supported
__snapshots__/tag/component/chromium/DBTag-should-be-a-radio-checked.png
Outdated
Show resolved
Hide resolved
__snapshots__/tag/component/chromium/DBTag-should-be-a-radio-checked.png
Outdated
Show resolved
Hide resolved
There are some additonal things:
|
@@ -428,6 +428,21 @@ $input-valid-types: | |||
} | |||
} | |||
|
|||
@mixin get-validity-color-check-label-color($state, $key: "valid") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we merge this with get-validity-color-check
? There is a similar selector. Maybe we should change the complete @mixin set-default-check-element
to use the $selector
instead of &:has(input:not([role="switch"]))
.
There is another hover
& pressed
function for the input and for the disabled state. By rewriting the complete set-default-check-element
we could save a lot of complexity. Just use hover pressed if not $selector=switch
or radio:checked
or input:disabled
blocked by #4096, which needs to get finished first. |
Proposed changes
Types of changes