Skip to content

feat: change color of label on hovered and active state #4077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

michaelmkraus
Copy link
Contributor

Proposed changes

  • change color of label on hovered and active state

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@michaelmkraus michaelmkraus moved this to 👀 In review in UX Engineering Team Backlog Apr 17, 2025
@github-actions github-actions bot added the 🧱 components Changes inside components folder label Apr 17, 2025
Copy link
Contributor

mfranzke
mfranzke previously approved these changes Apr 17, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • packages/components/src/styles/internal/_form-components.scss: Language not supported

@github-actions github-actions bot added the 📺 showcases Changes to 1-n showcases label Apr 17, 2025
@github-actions github-actions bot removed the 📺 showcases Changes to 1-n showcases label Apr 22, 2025
@nmerget
Copy link
Collaborator

nmerget commented Apr 23, 2025

There are some additonal things:

  • You need to check the disabled state the label is interactive
  • The radio[checked] shouldn't be interactive, the label shouldn't be interactive as well for this

@@ -428,6 +428,21 @@ $input-valid-types:
}
}

@mixin get-validity-color-check-label-color($state, $key: "valid") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge this with get-validity-color-check? There is a similar selector. Maybe we should change the complete @mixin set-default-check-element to use the $selector instead of &:has(input:not([role="switch"])).

There is another hover & pressed function for the input and for the disabled state. By rewriting the complete set-default-check-element we could save a lot of complexity. Just use hover pressed if not $selector=switch or radio:checked or input:disabled

@mfranzke
Copy link
Collaborator

mfranzke commented Apr 30, 2025

blocked by #4096, which needs to get finished first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧱 components Changes inside components folder
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants