-
Notifications
You must be signed in to change notification settings - Fork 10
feat: change color of label on hovered and active state #4077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michaelmkraus
wants to merge
10
commits into
main
Choose a base branch
from
feat-optimize-hover-data-inputs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
54c5c63
feat: change color of label on hovered and active state
michaelmkraus d961d48
Merge branch 'main' into feat-optimize-hover-data-inputs
mfranzke f7a60b2
test: updated snapshots
michaelmkraus 2105f1e
Merge remote-tracking branch 'origin/feat-optimize-hover-data-inputs'…
michaelmkraus 1f6876b
refactor: corrected snapshot
mfranzke 0b032f8
Merge remote-tracking branch 'origin/main' into feat-optimize-hover-d…
michaelmkraus 24c864a
test: updated that snapshot
mfranzke 48d07a0
Merge branch 'main' into feat-optimize-hover-data-inputs
michaelmkraus 6031b62
Merge branch 'main' into feat-optimize-hover-data-inputs
michaelmkraus 5d2a028
Merge branch 'main' into feat-optimize-hover-data-inputs
michaelmkraus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+42 Bytes
(100%)
__snapshots__/tag/component/chromium/DBTag-should-be-a-radio-checked.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+31 Bytes
(100%)
__snapshots__/tag/component/firefox/DBTag-should-be-a-radio-checked.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+42 Bytes
(100%)
__snapshots__/tag/component/mobile-chrome/DBTag-should-be-a-radio-checked.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we merge this with
get-validity-color-check
? There is a similar selector. Maybe we should change the complete@mixin set-default-check-element
to use the$selector
instead of&:has(input:not([role="switch"]))
.There is another
hover
&pressed
function for the input and for the disabled state. By rewriting the completeset-default-check-element
we could save a lot of complexity. Just use hover pressed if not$selector=switch
orradio:checked
orinput:disabled