-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Deprecating elasticsearch, kibana, and logstash #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for putting this together @yosifkit, I left a few comments.
elasticsearch/deprecated.md
Outdated
@@ -0,0 +1,3 @@ | |||
This image is officially deprecated in favor of [the `elasticsearh` image provided by elastic.co](https://www.elastic.co/guide/en/elasticsearch/reference/5.2/docker.html) which is available to pull via `docker.elastic.co/elasticsearch/elasticsearch:[version]` like `5.2.1`. This image will receive no further updates after 2017-06-20 (June 20, 2017). Please adjust your usage accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: elasticsearh
-> elasticsearch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's safe to link to current
instead of 5.2
, these top-level links are unlikely to change (and I'll have it in my head that if they do, we will need to submit a PR for the links to be changed).
elasticsearch/deprecated.md
Outdated
@@ -0,0 +1,3 @@ | |||
This image is officially deprecated in favor of [the `elasticsearh` image provided by elastic.co](https://www.elastic.co/guide/en/elasticsearch/reference/5.2/docker.html) which is available to pull via `docker.elastic.co/elasticsearch/elasticsearch:[version]` like `5.2.1`. This image will receive no further updates after 2017-06-20 (June 20, 2017). Please adjust your usage accordingly. | |||
|
|||
The team at Elastic.co prefer to offer Docker images on their infrastructure rather than through the "Official Images" program and the images are fully supported by them through their subscription program. You can also reach the community on the [forums](https://discuss.elastic.co/c/elasticsearch). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would prefer something like this, focusing strictly on non-commercial aspects:
Elastic provides open-source support for Elasticsearch via the elastic/elasticsearch GitHub repository and the Docker image via the elastic/elasticsearch-docker GitHub repository, as well as community support via its forums.
kibana/deprecated.md
Outdated
@@ -0,0 +1,3 @@ | |||
This image is officially deprecated in favor of [the `kibana` image provided by elastic.co](https://www.elastic.co/guide/en/kibana/5.2/_pulling_the_image.html) which is available to pull via `docker.elastic.co/kibana/kibana:[version]` like `5.2.1`. This image will receive no further updates after 2017-06-20 (June 20, 2017). Please adjust your usage accordingly. | |||
|
|||
The team at Elastic.co prefer to offer Docker images on their infrastructure rather than through the "Official Images" program and the images are fully supported by them through their subscription program. You can also reach the community on the [forums](https://discuss.elastic.co/c/kibana). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would prefer something like this, focusing strictly on non-commercial aspects:
Elastic provides open-source support for Kibana via the elastic/kibana GitHub repository and the Docker image via the elastic/kibana-docker GitHub repository, as well as community support via its forums.
logstash/deprecated.md
Outdated
@@ -0,0 +1,3 @@ | |||
This image is officially deprecated in favor of [the `logstash` image provided by elastic.co](https://www.elastic.co/guide/en/logstash/5.2/docker.html) which is available to pull via `docker.elastic.co/logstash/logstash:[version]` like `5.2.1`. This image will receive no further updates after 2017-06-20 (June 20, 2017). Please adjust your usage accordingly. | |||
|
|||
The team at Elastic.co prefer to offer Docker images on their infrastructure rather than through the "Official Images" program and the images are fully supported by them through their subscription program. You can also reach the community on the [forums](https://discuss.elastic.co/c/logstash). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would prefer something like this, focusing strictly on non-commercial aspects:
Elastic provides open-source support for Logstash via the elastic/logstash GitHub repository and the Docker image via the elastic/logstash-docker GitHub repository, as well as community support via its forums.
kibana/deprecated.md
Outdated
@@ -0,0 +1,3 @@ | |||
This image is officially deprecated in favor of [the `kibana` image provided by elastic.co](https://www.elastic.co/guide/en/kibana/5.2/_pulling_the_image.html) which is available to pull via `docker.elastic.co/kibana/kibana:[version]` like `5.2.1`. This image will receive no further updates after 2017-06-20 (June 20, 2017). Please adjust your usage accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's safe to link to current
instead of 5.2
, these top-level links are unlikely to change (and I'll have it in my head that if they do, we will need to submit a PR for the links to be changed).
logstash/deprecated.md
Outdated
@@ -0,0 +1,3 @@ | |||
This image is officially deprecated in favor of [the `logstash` image provided by elastic.co](https://www.elastic.co/guide/en/logstash/5.2/docker.html) which is available to pull via `docker.elastic.co/logstash/logstash:[version]` like `5.2.1`. This image will receive no further updates after 2017-06-20 (June 20, 2017). Please adjust your usage accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's safe to link to current
instead of 5.2
, these top-level links are unlikely to change (and I'll have it in my head that if they do, we will need to submit a PR for the links to be changed).
@jasontedor thanks for the comments! ❤️ I have updated with your recommendations. Can you review it once again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @yosifkit! ❤️ It looks great. |
This is the result of the discussion in docker-library/elasticsearch#160.
cc @jasontedor, I would appreciate feedback to ensure the wording is acceptable. I linked to elastic.co docs at version
5.2
instead ofcurrent
to ensure that any future docs changes won't break the links.This will appear at the top of the Docker Hub page, similar to rails.