Skip to content

Update deprecation notice #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2017
Merged

Update deprecation notice #945

merged 2 commits into from
Jun 22, 2017

Conversation

dliappis
Copy link
Contributor

Version 5.5 of the Elastic stack, including Elasticsearch, Kibana and Logstash has been delayed.

Update documentation clarifying that images will keep receiving updates until version 5.6.0.

Version 5.5 of the Elastic stack, including Elasticsearch, Kibana and
Logstash has been delayed.

Update documentation clarifying that images will keep receiving
updates until version 5.6.0.
@dliappis
Copy link
Contributor Author

cc @yosifkit who, so kindly, worked on the related #842

@tianon
Copy link
Member

tianon commented Jun 20, 2017

I've been looking at some of the Hub comments for these images since we added the deprecation notice, and wondering if we should maybe update this message to clarify that the reason the move is happening because this new image is maintained by Elastic, where the old image is not. What're your thoughts? Think that's worth clarifying further?

Otherwise this LGTM.

Once 5.6 is released, 5.5 is EOL, right? (wanting to make sure my previous understanding is correct and that I'm parsing this update properly 😅)

@tianon
Copy link
Member

tianon commented Jun 20, 2017

Probably also worth CCing @jasontedor 😄

@elasticdog
Copy link

A slightly reworded version based on @tianon's suggestion:

This image has been deprecated in favor of the official elasticsearch image provided and maintained by elastic.co. The upstream images are available to pull via docker.elastic.co/elasticsearch/elasticsearch:[version] like 5.4.1. The images found here will receive no further updates once the 5.6.0 release is available upstream. Please adjust your usage accordingly.

@dliappis
Copy link
Contributor Author

I am happy with @elasticdog's rewording above; @tianon what do you think? If it's LGTM grade :) I can update my PR.

@tianon
Copy link
Member

tianon commented Jun 21, 2017

Sounds fine to me! Don't have strong opinions here, just figured I'd point out what users are saying in case it helps get something that makes it easier for them to understand why this is happening. 👍 ❤️

@jasontedor
Copy link

I'm good with it too. Thanks for the iteration @tianon!

@dliappis
Copy link
Contributor Author

I pushed @elasticdog's reworded deprecated notice.

@dliappis
Copy link
Contributor Author

... and many thanks @tianon for reviewing and all the ❤️ and understanding!

@tianon tianon merged commit 8dc8083 into docker-library:master Jun 22, 2017
This was referenced Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants