This repository was archived by the owner on Oct 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#148 fixes build with symfony 4.2 - this will be merged to 1.3 before continuing with this PR. |
xabbuh
reviewed
Nov 8, 2018
alcaeus
commented
Nov 9, 2018
Majkl578
approved these changes
Nov 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd drop the alignments in composer.json, the rest is 👍.
8e86c3a
to
730d86b
Compare
Build is stable for now, but it seems travis has the |
730d86b
to
17072b1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops support for all PHP versions < 7.1 as they are no longer supported. PHP 7.1 is kept to be aligned to the Symfony 4 minimum requirement. Note that we will provide bugfixes for older PHP versions in the 1.3 branch if necessary.