This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Fix deprecation in tree builder for Symfony 4.2+ #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Disabled
We'll be introducing Doctrine CS in master soon, so no need for a weird coding standard here. |
xabbuh
reviewed
Nov 8, 2018
xabbuh
reviewed
Nov 8, 2018
|
I noticed that @javiereguiluz created #143 a while back, but builds there fail. Seems like I forgot a couple of instances as well, so I'll clean this up later today. |
alcaeus
force-pushed
the
fix-tree-builder-deprecation
branch
from
9e89b5f to
8e9e512
Compare
alcaeus
force-pushed
the
fix-tree-builder-deprecation
branch
from
8e9e512 to
f28b486
Compare
stof
approved these changes
Nov 8, 2018
|
Build failures on PHP 5.3 and 5.5 are unrelated to this change, will investigate them separately. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See doctrine/DoctrineBundle#853 - I forgot this in the previous 1.3 release but it should indeed be fixed in 1.3 before we drop support for old stuff for 1.4.