You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// IReadOnlyList, yet it has an Add. Why isn't it IList?// Of course, there's also// Guideline: DO use the “Collection” suffix in names of types implementing IEnumerable (or any of its descendants) and representing a list of items.// So "CompletionSourceCollection" is the name the guidelines suggest. (It doesn't get the exception of "if you're just being a general data structure and explaining the kind of data structure" that List has)// Why doesn't this look like other collections? (Count property, etc)?publicclassCompletionSourceList:IEnumerable<ICompletionSource>,IReadOnlyCollection<ICompletionSource>,IReadOnlyList<ICompletionSource>,IEnumerable{publicCompletionSourceList();publicintCount{get;}publicICompletionSourceItem{get;}publicvoidAdd(ICompletionSourcesource);publicvoidClear();publicIEnumerator<ICompletionSource>GetEnumerator();}
The text was updated successfully, but these errors were encountered:
…on (#1946)
* remove CompletionSourceList, expose a ICollection<ICompletionSource> instead:
- it has Add and Clear
- it has no indexer, but we don't need it
fixes#1911
* replace CompletionDelegate with a Func, fixes#1927
* remove DirectiveCollection, use dictionary instead, fixes#1912
* replace HelpSectionDelegate with Action<HelpContext>, fixes#1932
* replace ParseArgument<T> with Func<ArgumentResult, T>, fixes#1939
* Replace ValidateSymbolResult delegate with Action<T>, fixes#1944
The text was updated successfully, but these errors were encountered: