Skip to content

Increase time out on build to 45 #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2018
Merged

Increase time out on build to 45 #1598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/ci/phase-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ phases:
_phaseName: ${{ parameters.name }}
_arch: ${{ parameters.architecture }}
queue:
timeoutInMinutes: 40
timeoutInMinutes: 45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why move from 40 to only 45? If it's dying at 40, do we think the extra 12.5% allowed runtime will be enough?

How about we first set a higher limit then see how much time it will take:

Suggested change
timeoutInMinutes: 45
timeoutInMinutes: 60

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to be 60 before, we can change it again if needed, but the ones I looked at yesterday were almost finished before cancelling.

parallel: 99
matrix:
Build_Debug:
Expand Down