Increase time out on build to 45 #1598
Conversation
|
@shauheen do you have example of such build? If you look on build for this PR it's all done in 20 minutes. |
|
@Ivanidzo4ka all of the builds on master have failed since yesterday because one leg is cancelled at 40 minutes. |
| @@ -11,7 +11,7 @@ phases: | |||
| _phaseName: ${{ parameters.name }} | |||
| _arch: ${{ parameters.architecture }} | |||
| queue: | |||
| timeoutInMinutes: 40 | |||
| timeoutInMinutes: 45 | |||
There was a problem hiding this comment.
Why move from 40 to only 45? If it's dying at 40, do we think the extra 12.5% allowed runtime will be enough?
How about we first set a higher limit then see how much time it will take:
| timeoutInMinutes: 45 | |
| timeoutInMinutes: 60 |
There was a problem hiding this comment.
It used to be 60 before, we can change it again if needed, but the ones I looked at yesterday were almost finished before cancelling.
There was a problem hiding this comment.
Do we know which steps are taking the most time? Do we have a plan to speed them up?
In @shauheen's link the overall time for the OSX Debug build/test was ~2x longer than the debug build on Linux/Windows.
I did note that we may want longer timeout to first find the right limit, then later we can reduce it.
|
@shauheen lets look in the log:
It didn't fail because it was working and didn't had time, it fail because it got stuck and got terminated during timeout. As I said, in successful build you have about 20 minutes of execution, by increasing timeout, you only make situation worse, I would rather change timeout to 30 or maybe 25 minutes, than increasing it. We just block machines in the pool for longer period of time. |
ghost
locked as resolved and limited conversation to collaborators
I'm seeing builds getting cancelled at 40 minutes which might have completed otherwise. Increasing timeout to 45 minutes, in #1561 it was suggested we should bump this as well.