Skip to content

XML docs for Permutation feature importance for Binary, Multi-class and Ranking trainers. #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 22, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented Apr 22, 2019

towards #3204

@codemzs codemzs added the documentation Related to documentation of ML.NET label Apr 22, 2019
Copy link
Contributor

@artidoro artidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #3455 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3455      +/-   ##
==========================================
- Coverage   72.77%   72.77%   -0.01%     
==========================================
  Files         808      808              
  Lines      145449   145452       +3     
  Branches    16244    16244              
==========================================
+ Hits       105844   105846       +2     
- Misses      35186    35188       +2     
+ Partials     4419     4418       -1
Flag Coverage Δ
#Debug 72.77% <ø> (-0.01%) ⬇️
#production 68.28% <ø> (-0.01%) ⬇️
#test 89.04% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.LightGbm/LightGbmCatalog.cs 100% <ø> (ø) ⬆️
...ansforms/PermutationFeatureImportanceExtensions.cs 97.93% <ø> (ø) ⬆️
src/Microsoft.ML.FastTree/TreeTrainersCatalog.cs 94.18% <ø> (ø) ⬆️
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
src/Microsoft.ML.Transforms/OneHotHashEncoding.cs 88.09% <0%> (ø) ⬆️
src/Microsoft.ML.Transforms/NormalizerCatalog.cs 84.78% <0%> (ø) ⬆️
src/Microsoft.ML.Transforms/OneHotEncoding.cs 86.07% <0%> (ø) ⬆️
src/Microsoft.ML.Transforms/GcnTransform.cs 77.57% <0%> (+0.1%) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 85.11% <0%> (+0.2%) ⬆️
...StandardTrainers/Standard/LinearModelParameters.cs 60.31% <0%> (+0.26%) ⬆️
... and 1 more

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shmoradims
Copy link

shmoradims commented Apr 22, 2019

    /// the original values for all other features. The evalution metric (e.g. micro-accuracy) is then calculated

typo: evaluation (same typo in all versions) #Closed


Refers to: src/Microsoft.ML.Transforms/PermutationFeatureImportanceExtensions.cs:191 in cf3f0ef. [](commit_id = cf3f0ef, deletion_comment = False)

@shmoradims
Copy link

shmoradims commented Apr 22, 2019

    /// <code>ImmutableArray</code> of <code>MulticlassClassificationMetrics</code> objects is returned. See the sample below for an

use cref instead of (which doesn't render correctly):

of

same with all overloads #Closed


Refers to: src/Microsoft.ML.Transforms/PermutationFeatureImportanceExtensions.cs:198 in cf3f0ef. [](commit_id = cf3f0ef73259937935fa15f13018803f0b8a6f83, deletion_comment = False)

Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit f829b34 into dotnet:master Apr 22, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Related to documentation of ML.NET
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants