Skip to content

Travis: add 2.4, 2.5 to CI matrix #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Jan 20, 2018

As I was interested in the IPv6 support PR, I tried running the tests on my laptop.

There was a NoMethodError on Ruby 2.5, which was absent on Ruby 2.4.

Error:
TestNetHttpPersistent#test_pipeline:
NoMethodError: undefined method `start' for #<Net::HTTP::Persistent::Connection:0x00007fed77921258>
    /opt/src/opensource/ruby/net-http-persistent/test/test_net_http_persistent.rb:754:in `test_pipeline'

So, I

  • added both of these release series to the CI matrix.
  • modified the test to call start on http - would this be the right way?

@olleolleolle olleolleolle changed the title Fix/travis with 25 Travis: add 2.4, 2.5 to CI matrix Jan 20, 2018
@grosser
Copy link
Contributor

grosser commented May 13, 2019

@drbrain @olleolleolle this can be closed

@drbrain drbrain closed this May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants