Skip to content

Travis: add 2.4, 2.5 to CI matrix #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Travis: add 2.4, 2.5 to CI matrix #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a075b34
Travis CI matrix: add 2.4, 2.5
olleolleolle Jan 20, 2018
7b89397
Call connection.http.start instead of connection.start
olleolleolle Jan 20, 2018
ef2fc1c
CI: Use 2.4.6, 2.5.5, 2.6.2
olleolleolle Apr 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,7 @@ rvm:
- 2.1.10
- 2.2.5
- 2.3.1
- 2.4.6
- 2.5.5
- 2.6.2
script: rake travis
6 changes: 3 additions & 3 deletions test/test_net_http_persistent.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def proxy_port
def basic_connection
raise "#{@uri} is not HTTP" unless @uri.scheme.downcase == 'http'

net_http_args = [@uri.host, @uri.port]
net_http_args = [@uri.hostname, @uri.port]

connection = Net::HTTP::Persistent::Connection.allocate
connection.ssl_generation = @http.ssl_generation
Expand Down Expand Up @@ -152,7 +152,7 @@ def r.read_body() :read_body end
def ssl_connection
raise "#{@uri} is not HTTPS" unless @uri.scheme.downcase == 'https'

net_http_args = [@uri.host, @uri.port]
net_http_args = [@uri.hostname, @uri.port]

connection = Net::HTTP::Persistent::Connection.allocate
connection.ssl_generation = @http.ssl_generation
Expand Down Expand Up @@ -751,7 +751,7 @@ def test_pipeline
skip 'net-http-pipeline not installed' unless defined?(Net::HTTP::Pipeline)

cached = basic_connection
cached.start
cached.http.start

requests = [
Net::HTTP::Get.new((@uri + '1').request_uri),
Expand Down