fix: support Lambda instrumentation for contextManager: 'patch'; refactor Lambda tests
#3305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
agent-nodejs
1 task
v1v
added a commit
to v1v/apm-agent-nodejs
that referenced
this pull request
May 8, 2023
…re/support-specific-modules * 'main' of github.com:elastic/apm-agent-nodejs: (54 commits) chore: fix dev-utils/ci-tav-slow-jobs.sh (elastic#3319) test: reduce TAV test matrix for slowest jobs (elastic#3321) chore: sync package-lock so 'npm ci' can work (elastic#3318) docs: document `useElasticTraceparentHeader` config var (elastic#3316) chore, test: test driver improvements (elastic#3293) test: drop node 14 from RC tests now that it is EOL (elastic#3315) test: fix running fastify.test.js with node v8 (elastic#3317) feat: add @apollo/server@4 support (elastic#3203) chore: update nvm (elastic#3309) tests: stop testing 'express-graphql' instrumentation (elastic#3304) chore: fix bitrot.js dev util for recent changes (elastic#3308) test: restore testing of Azure Functions on node >=18.x (elastic#3307) fix: support Lambda instrumentation for `contextManager: 'patch'`; refactor Lambda tests (elastic#3305) test: fix fastify TAV test failures (elastic#3314) test: fix @aws-sdk/client-s3 TAV test failures (elastic#3312) feat: add instrumentation for aws-sdk S3 client (elastic#3287) feat(fastify): add captureBody support (elastic#2681) feat: mysql2@3 support (elastic#3301) chore(deps): bump @opentelemetry/exporter-prometheus from 0.37.0 to 0.38.0 in /test/opentelemetry-metrics/fixtures (elastic#3295) chore(deps-dev): bump fastify from 4.16.3 to 4.17.0 (elastic#3296) ...
trentm
added a commit
that referenced
this pull request
May 16, 2023
…factor Lambda tests (#3305) Changes in #3285 broke Lambda instrumentation if the deprecated `contextManager:'patch' config var was used. This restores support for that, FWIW. Also, refactoring so we can drop AgentMock and TransactionMock under test/lambda/... to simplify: - roll promises.test.js into the main test file - roll trace-context.test.js into the main lambda test file - roll transaction.test.js into main lambda test file - rename main lambda test file to lambda.test.js - drop now unused MockAgent
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
…factor Lambda tests (elastic#3305) Changes in elastic#3285 broke Lambda instrumentation if the deprecated `contextManager:'patch' config var was used. This restores support for that, FWIW. Also, refactoring so we can drop AgentMock and TransactionMock under test/lambda/... to simplify: - roll promises.test.js into the main test file - roll trace-context.test.js into the main lambda test file - roll transaction.test.js into main lambda test file - rename main lambda test file to lambda.test.js - drop now unused MockAgent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use explicit RunContext handling so even contextManager:'patch' works
Refactoring so we can drop AgentMock and TransactionMock under test/lambda/...