test: fix @aws-sdk/client-s3 TAV test failures

[david-luna]

• Fix for bad selection of docker compose file to run tests on module @aws-sdk/client-s3. Test script was selecting the default one instead of using one with localstack.
• Bump the min supported client-s3 version to v3.15.0.
• Also a small fix in intake event sorting for tests

Fixes: #3311

Checklist

• Implement code (in CI scripts)
• Commit message follows commit guidelines

[david-luna]

I've run the tests in local with the command

./.ci/scripts/test.sh -b "release" -t "@aws-sdk/client-s3" "20"

I'm still getting an error when testing v3.0.0 of the module though with a similar error message

docker-node_tests-1  | -- required packages ["@aws-sdk/[email protected]"]
docker-node_tests-1  | -- installing ["@aws-sdk/[email protected]"]
docker-node_tests-1  | -- running test "node test/instrumentation/modules/@aws-sdk/client-s3.test.js" with @aws-sdk/client-s3
docker-node_tests-1  | /app/test/instrumentation/modules/@aws-sdk/client-s3.test.js:105
docker-node_tests-1  |         const failingSpanId = spans[7].id // index of `getObjNonExistantObject`
docker-node_tests-1  |                                        ^
docker-node_tests-1  |
docker-node_tests-1  | TypeError: Cannot read properties of undefined (reading 'id')
docker-node_tests-1  |     at done (/app/test/instrumentation/modules/@aws-sdk/client-s3.test.js:105:40)
docker-node_tests-1  |     at ChildProcess.exithandler (node:child_process:427:5)
docker-node_tests-1  |     at ChildProcess.emit (node:events:511:28)
docker-node_tests-1  |     at maybeClose (node:internal/child_process:1098:16)
docker-node_tests-1  |     at ChildProcess._handle.onexit (node:internal/child_process:304:5)

[trentm]

I'm still getting an error when testing v3.0.0 of the module

Perhaps we don't need to go back that far for support. It was released in 2020:

  '3.0.0': '2020-12-15T23:03:11.641Z',

[trentm]

Our test starts failing at v3.14.0. I'll add a commit to make that our base supported version. This will broaden the scope of this PR to fix #3311

[trentm]

Some context on commit 396fd6c. I was testing locally with a manually started 'localstack' docker container. From an earlier test failure the test bucket had not been deleted. A subsequent test run resulted in the CreateBucket command not being run, so the expected spans were wrong. Because of the sorting bug the test error was this obtuse error:

not ok 3 got the transaction
  ---
    operator: ok
    expected: true
    actual:   undefined
    at: done (/Users/trentm/el/apm-agent-nodejs15/test/instrumentation/modules/@aws-sdk/client-s3.test.js:97:11)
    stack: |-
      Error: got the transaction
          at Test.assert [as _assert] (/Users/trentm/el/apm-agent-nodejs15/node_modules/tape/lib/test.js:312:48)
          at Test.bound [as _assert] (/Users/trentm/el/apm-agent-nodejs15/node_modules/tape/lib/test.js:95:17)
          at Test.assert (/Users/trentm/el/apm-agent-nodejs15/node_modules/tape/lib/test.js:431:7)
          at Test.bound [as ok] (/Users/trentm/el/apm-agent-nodejs15/node_modules/tape/lib/test.js:95:17)
          at done (/Users/trentm/el/apm-agent-nodejs15/test/instrumentation/modules/@aws-sdk/client-s3.test.js:97:11)
          at ChildProcess.exithandler (node:child_process:394:7)
          at ChildProcess.emit (node:events:513:28)
          at maybeClose (node:internal/child_process:1100:16)
          at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)
  ...
ok 4 span is valid (per apm-server intake schema)
ok 5 span is valid (per apm-server intake schema)
ok 6 span is valid (per apm-server intake schema)
ok 7 span is valid (per apm-server intake schema)
ok 8 span is valid (per apm-server intake schema)
ok 9 span is valid (per apm-server intake schema)
ok 10 span is valid (per apm-server intake schema)
/Users/trentm/el/apm-agent-nodejs15/test/instrumentation/modules/@aws-sdk/client-s3.test.js:108
        t.equal(spans.filter(s => s.trace_id === tx.trace_id).length,
                                                    ^

TypeError: Cannot read properties of undefined (reading 'trace_id')
    at /Users/trentm/el/apm-agent-nodejs15/test/instrumentation/modules/@aws-sdk/client-s3.test.js:108:53

After the sorting fix it was this clearer error:

not ok 17 createTheBucketIfNecessary produced expected span
  ---
    operator: deepEqual
    expected: |-
      { name: 'S3 CreateBucket elasticapmtest-bucket-3', type: 'storage', subtype: 's3', action: 'CreateBucket', context: { service: { target: { type: 's3', name: 'elasticapmtest-bucket-3' } }, destination: { address: 'localhost', port: 4566, cloud: { region: 'us-east-2' }, service: { type: '', name: '', resource: 'elasticapmtest-bucket-3' } }, http: { status_code: 200, response: { encoded_body_size: 177 } } }, otel: { attributes: { 'aws.s3.bucket': 'elasticapmtest-bucket-3' } }, outcome: 'success' }
    actual: |-
      { name: 'S3 HeadBucket elasticapmtest-bucket-3', type: 'storage', subtype: 's3', action: 'HeadBucket', context: { service: { target: { type: 's3', name: 'elasticapmtest-bucket-3' } }, destination: { address: 'localhost', port: 4566, service: { name: '', type: '', resource: 'elasticapmtest-bucket-3' }, cloud: { region: 'us-east-2' } }, http: { status_code: 200, response: { encoded_body_size: 0 } } }, outcome: 'success', otel: { attributes: { 'aws.s3.bucket': 'elasticapmtest-bucket-3' } } }
    at: done (/Users/trentm/el/apm-agent-nodejs15/test/instrumentation/modules/@aws-sdk/client-s3.test.js:147:11)
    stack: |-
      Error: createTheBucketIfNecessary produced expected span
          at Test.assert [as _assert] (/Users/trentm/el/apm-agent-nodejs15/node_modules/tape/lib/test.js:312:48)
          at Test.bound [as _assert] (/Users/trentm/el/apm-agent-nodejs15/node_modules/tape/lib/test.js:95:17)
          at Test.tapeDeepEqual (/Users/trentm/el/apm-agent-nodejs15/node_modules/tape/lib/test.js:553:7)
          at Test.bound [as deepEqual] (/Users/trentm/el/apm-agent-nodejs15/node_modules/tape/lib/test.js:95:17)
          at done (/Users/trentm/el/apm-agent-nodejs15/test/instrumentation/modules/@aws-sdk/client-s3.test.js:147:11)
          at ChildProcess.exithandler (node:child_process:394:7)
          at ChildProcess.emit (node:events:513:28)
          at maybeClose (node:internal/child_process:1100:16)
          at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)
  ...