Removing a branch from a book doesn't clear its metadata #973
Comments
This was referenced Jul 9, 2019
nik9000
added a commit
that referenced
this issue
Jul 10, 2019
We keep information about which branches contribute to which books but before this change we didn't automatically remove the metadata when a branch is no longer involved in building a book we never cleared that metadata. For the most part this just left lines in a YAML file that aren't used except when we remove a branch from a book and then re-add it. In that case since we only use the branch data to figure out if we should rebuild a book we *wouldn't* start to build the book when it is added back unless the branch that it is built from changes. This happened to us recently so it makes sense to clean up these files automatically so it never happens again. Closes #973
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use branch metadata to figure out if a book needs to be rebuilt. When you remove a branch from a book we don't clear the metadata. This leads to weird things like not automatically rebuilding books when the branch is re-added.
The text was updated successfully, but these errors were encountered: