Automatically clean up book metadata #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olksdr could you have a look at this one please? |
nik9000
commented
Jul 9, 2019
lib/ES/BranchTracker.pm
Outdated
| # tell if it'll be needed again. It is a problem, but not a big one | ||
| # right now. | ||
| unless ($allowed_for_repo->{$branch} || $branch =~ /^link-check/) { | ||
| say "Pruning for $repo $branch"; |
There was a problem hiding this comment.
This is leftover debugging info and I'll remove before committing.
olksdr
approved these changes
Jul 10, 2019
lib/ES/BranchTracker.pm
Outdated
| delete $branches->{$branch}; | ||
| } | ||
| } | ||
| # Empty can show up because there is a new book that weren't not |
There was a problem hiding this comment.
I think one not too many here -> book that weren't not
|
Thanks for reviewing @olksdr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep information about which branches contribute to which books but
before this change we didn't automatically remove the metadata when
a branch is no longer involved in building a book we never cleared that
metadata. For the most part this just left lines in a YAML file that
aren't used except when we remove a branch from a book and then re-add
it. In that case since we only use the branch data to figure out if we
should rebuild a book we wouldn't start to build the book when it is
added back unless the branch that it is built from changes. This happened
to us recently so it makes sense to clean up these files automatically
so it never happens again.
Closes #973