Create a "live" branches config for books #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've wanted for a while to mark old versions of books as "noindex" and, probably, to remove the `edit_me` links from them. This creates a config entry for `conf.yaml` to mark branches as "live". If this list is specified then everything *not* in the list will be marked as `noindex`. In the future we might remove the edit links from it was well. This applies that config change to the installation and upgrade guide, just to apply it to something for testing. I think we'll want to apply it to most books eventually.
olksdr
approved these changes
Nov 19, 2019
| end | ||
| yaml | ||
| end | ||
| end |
There was a problem hiding this comment.
you build here a lot of yaml by hand. Maybe it's worth pulling yaml lib for this and use ruby hashes/lists to build the structure you want and then just to_yaml it?
There was a problem hiding this comment.
I'm going to investigate that again.... The last time I tried it didn't work because the yaml library emitted yaml that perl couldn't read!
|
Relates to #1419. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've wanted for a while to mark old versions of books as "noindex" and,
probably, to remove the
edit_melinks from them. This creates a configentry for
conf.yamlto mark branches as "live". If this list isspecified then everything not in the list will be marked as
noindex.In the future we might remove the edit links from it was well.
This applies that config change to the installation and upgrade guide,
just to apply it to something for testing. I think we'll want to apply
it to most books eventually.