Skip to content

Add "live" branches for APM agents #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Nov 19, 2019

Full details in #1421 & #1419. To summarize:

We've wanted for a while to mark old versions of books as "noindex" and,
probably, to remove the edit_me links from them. This creates a config
entry for conf.yaml to mark branches as "live".

This PR sets live branches for the APM agents. Specifically, it marks only master and the current version of each agent as live. @lreuven (or maybe @axw?) can you confirm there are no other branches that should also be marked as live?

@bmorelli25 bmorelli25 self-assigned this Nov 19, 2019
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this if everyone else is!

@axw
Copy link
Member

axw commented Nov 20, 2019

I think those are the right branches.

@bmorelli25 bmorelli25 merged commit 9904be2 into elastic:master Nov 20, 2019
@bmorelli25 bmorelli25 deleted the apm-agent-live branch November 20, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants