Revised default notice for older versions. #1528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedemorton
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
LGTM!
At some point, we could automatically apply the correct notice to "live" versions that aren't current and eliminate even that manual step.
This is a good idea. For now, we should add a reminder to our doc release process to make sure the notices get updated when necessary.
This was referenced Dec 6, 2019
|
I've merged the overrides for 6.8 in the docs that use the stack versioning. This default notice will be applied to versions that don't have an explicit page_header.html file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the default notice for versions older than current. With this change, we do not have to override the default notice in every OOM version, but we will have to override it for the maintenance version of the previous minor (currently 6.8).
That's simpler than having to do that for every OOM version, so I think it's a win. At some point, we could automatically apply the correct notice to "live" versions that aren't current and eliminate even that manual step.