Skip to content

[DOCS] Added older release notice. #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Conversation

debadair
Copy link
Contributor

@debadair debadair commented Dec 9, 2019

Explicitly set page_header.html for 6.x so that the default notice can be updated for OOM versions.

Prerequisite for: elastic/docs#1528

@debadair debadair requested a review from jrodewig December 9, 2019 22:13
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam
Copy link
Contributor

russcam commented Dec 9, 2019

Thanks @debadair. Is there an asciidoc attribute we can use to include the admonition, instead of HTML, or is the HTML snippet the recommended approach?

@debadair
Copy link
Contributor Author

@russcam The HTML snippet is currently the only way to inject the banner at the top of the page.

@Mpdreamz Mpdreamz merged commit 6dd02c1 into elastic:6.x Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants