Skip to content

Drop "out of date" from version drop down #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Drop "out of date" from version drop down #1546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integtest/spec/all_books_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ def self.setup_example(repo, lang, hash)
context 'the live versions drop down' do
it 'contains the deprecated branch' do
expect(body).to include(<<~HTML.strip)
<select id="live_versions"><option value="master">master (current)</option><option value="nonlive" selected>nonlive (out of date)</option></select>
<select id="live_versions"><option value="master">master (current)</option><option value="nonlive" selected>nonlive</option></select>
HTML
end
end
Expand Down
1 change: 0 additions & 1 deletion lib/ES/Book.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,6 @@ sub _update_title_and_version_drop_downs {
$title .= ' selected' if $branch eq $b;
$title .= '>' . $self->branch_title($b);
$title .= ' (current)' if $self->current eq $b;
$title .= ' (out of date)' unless $live;
$title .= '</option>';
}
$title .= '<option value="other">other versions</option>' if $removed_any;
Expand Down