Review handling of status code in HTTP requests #1549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
force-pushed
the
http-unexpected-status-codes
branch
from
1f5c8d9 to
2dc182d
Compare
mrodm
reviewed
Nov 9, 2023
jsoriano
commented
Nov 9, 2023
| // No docs yet. | ||
| return &hits{}, nil | ||
| } | ||
| if resp.StatusCode == http.StatusServiceUnavailable && strings.Contains(resp.String(), "no_shard_available_exception") { |
There was a problem hiding this comment.
FTR, this is the error I saw that made me to handle this case:
Error: error running package system tests: could not complete test run: failed to search docs for data stream metrics-apache.status-ep: [503 Service Unavailable] {"error":{"root_cause":[{"type":"no_shard_available_action_exception","reason":null}],"type":"search_phase_execution_exception","reason":"all shards failed","phase":"query","grouped":true,"failed_shards":[{"shard":0,"index":".ds-metrics-apache.status-ep-2023.11.09-000001","node":null,"reason":{"type":"no_shard_available_action_exception","reason":null}}]},"status":503}
bf6b99a to
f2246ac
Compare
|
/test |
mrodm
approved these changes
Nov 10, 2023
|
test integrations |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#8460 |
jsoriano
commented
Nov 10, 2023
|
test integrations |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#8460 |
|
test integrations |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#8460 |
💚 Build Succeeded
History
cc @jsoriano |
|
I had to do some fixes after testing with integrations, it seems to be fine now @mrodm could you re-review? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a number of places we were not handling HTTP status codes, what may hide issues
or complicate debugging.
Also ensure that body is closed in all cases.
Fixes #1486