Skip to content

Remove ML system_annotations_retention_days setting #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

droberts195
Copy link
Contributor

This is a reversion of #522.

We decided not to add a new setting after all, but to
use results_retention_days for both results and system
annotations (on the basis that system annotations are
a type of result).

This setting has been added and removed within the 7.15
development cycle so there are no implications for
anyone using released product.

Relates to elastic/elasticsearch#76096

This is a reversion of elastic#522.

We decided not to add a new setting after all, but to
use results_retention_days for both results and system
annotations (on the basis that system annotations are
a type of result).

This setting has been added and removed within the 7.15
development cycle so there are no implications for
anyone using released product.
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson sethmlarson merged commit 1c92c46 into elastic:main Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants