[ML] Use results retention time for deleting system annotations #76096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#75617 a new setting, system_annotations_retention_days, was added to control how long system annotations are retained for. We now feel that this setting is redundant and that system annotations should be retained for the same period as results. This is intuitive and defensible, as system annotations can be considered a type of result. Followup to elastic#75617
|
Pinging @elastic/ml-core (Team:ML) |
|
|
benwtrent
approved these changes
Aug 4, 2021
docs/reference/ml/ml-shared.asciidoc
Outdated
| @@ -1433,16 +1433,6 @@ bucket result are deleted from {es}. The default value is null, which means all | |||
| results are retained. | |||
There was a problem hiding this comment.
We should comment here that system created annotations are also deleted.
| @@ -193,7 +192,9 @@ public void writeTo(StreamOutput out) throws IOException { | |||
| out.writeOptionalLong(modelSnapshotRetentionDays); | |||
| out.writeOptionalLong(dailyModelSnapshotRetentionAfterDays); | |||
| out.writeOptionalLong(resultsRetentionDays); | |||
| out.writeOptionalLong(systemAnnotationsRetentionDays); | |||
| if (out.getVersion().onOrAfter(Version.V_7_15_0) && out.getVersion().before(Version.V_8_0_0)) { | |||
| out.writeOptionalLong(null); | |||
There was a problem hiding this comment.
I think technically this should be out.writeOptionalLong(resultsRetentionDays);
But, that doesn't matter really as when this change is backported this branch is removed.
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Aug 4, 2021
Remove the last bits of code after the backport PR (elastic#76113) is merged. Followup to elastic#76096
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Aug 4, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 4, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 4, 2021
* [ML] Use results retention time for deleting system annotations In #75617 a new setting, system_annotations_retention_days, was added to control how long system annotations are retained for. We now feel that this setting is redundant and that system annotations should be retained for the same period as results. This is intuitive and defensible, as system annotations can be considered a type of result. Backport of #76096 * Fix one more merge clash
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 4, 2021
* [ML] Removing last traces of system_annotations_retention_days Remove the last bits of code after the backport PR (#76113) is merged. Followup to #76096 * unmute bwc tests Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Benjamin Trent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #75617 a new setting, system_annotations_retention_days, was
added to control how long system annotations are retained for.
We now feel that this setting is redundant and that system
annotations should be retained for the same period as results.
This is intuitive and defensible, as system annotations can be
considered a type of result.
Followup to #75617