Switch to CBOR as default packing mode #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches the default packing mode from JSON to CBOR. It also always adds the "binary_encoding" field to the REST requests, which is how the server decides what to answer with (the ES/SQL plugin overrides the Accept HTTP header).
bpintea
added a commit
that referenced
this pull request
Mar 17, 2020
This commit switches the default packing mode from JSON to CBOR. It also always adds the "binary_encoding" field to the REST requests, which is how the server decides what to answer with (the ES/SQL plugin overrides the Accept HTTP header). (cherry picked from commit c6639ab)
bpintea
added a commit
that referenced
this pull request
Mar 17, 2020
This commit switches the default packing mode from JSON to CBOR. It also always adds the "binary_encoding" field to the REST requests, which is how the server decides what to answer with (the ES/SQL plugin overrides the Accept HTTP header). (cherry picked from commit c6639ab)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the default packing mode from JSON to CBOR.
It also always adds the "binary_encoding" boolean field to the REST requests,
which is how the server decides what to answer with (the ES/SQL plugin
overrides the Accept HTTP header).