Add catalog support #297
Merged
Add catalog support #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for multiple catalogs ("databases").
The client application can now set the catalog at connection level -
with SQLSetConnectAttr - to a pattern matching a local or remote cluster
name and ES/SQL will execute the query on the respective cluster/s.
A default catalog can also be set through the connection string, through
the "Catalog" DSN attribute.
In case the catalog is not set, or set to an empty or null string, the
local catalog will be chosen for execution.
The driver will simply add a "catalog" request attribute containing the
value received from the application, or skip adding the attribute if
this is empty.
bpintea
added
>feature
bpintea
commented
Oct 18, 2021
| #define REQ_KEY_BINARY_FMT "binary_format" | ||
|
|
||
| #define REST_REQ_KEY_COUNT 13 /* "query" / "cursor" count as one */ |
There was a problem hiding this comment.
The count bump was skipped in #215/#216, but fortunately to no bad outcome, since values between 9 and 15 would be treated the same by cbor_nn_hdr_len().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for multiple catalogs ("databases").
The client application can now set the catalog at connection level -
with SQLSetConnectAttr - to a pattern matching a local or remote cluster
name and ES/SQL will execute the query on the respective cluster/s.
A default catalog can also be set through the connection string, through
the "Catalog" DSN attribute.
In case the catalog is not set, or set to an empty or null string, the
local catalog will be chosen for execution.
The driver will simply add a "catalog" request attribute containing the
value received from the application, or skip adding the attribute if
this is empty.
Relates to elastic/elasticsearch#78903.