Add an early execution mode for prepared statements #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an early execution mode for prepared queries. Applications generally prepare a statement, optionally reading result set attributes - like columns count and their characteristics (types and names) - before executing. A subset of these apps (generally the ones following older API usage patterns) will fail the entire operation if these column characteristics aren't available before execution. Elasticsearch/SQL doesn't support the concept of prepared statements. What the driver will now do if this mode is enabled (=the new default) is to execute the query right away, in case this lacks any parameters. In case the parameter marks are present, the early execution is disabled for the statement (and potentially the query will fail). However, most patterns of Elasticsearch/ODBC usage don't involve paramters and/or repeated executions. This change should allow more applications interop with Elasticsearch/SQL.
bpintea
added
>feature
bpintea
added a commit
that referenced
this pull request
Mar 30, 2020
This commit adds an early execution mode for prepared queries. Applications generally prepare a statement, optionally reading result set attributes - like columns count and their characteristics (types and names) - before executing. A subset of these apps (generally the ones following older API usage patterns) will fail the entire operation if these column characteristics aren't available before execution. Elasticsearch/SQL doesn't support the concept of prepared statements. What the driver will now do if this mode is enabled (=the new default) is to execute the query right away, in case this lacks any parameters. In case the parameter marks are present, the early execution is disabled for the statement (and potentially the query will fail). However, most patterns of Elasticsearch/ODBC usage don't involve paramters and/or repeated executions. This change should allow more applications interop with Elasticsearch/SQL. (cherry picked from commit 5a1d4be)
bpintea
added a commit
that referenced
this pull request
Mar 30, 2020
This commit adds an early execution mode for prepared queries. Applications generally prepare a statement, optionally reading result set attributes - like columns count and their characteristics (types and names) - before executing. A subset of these apps (generally the ones following older API usage patterns) will fail the entire operation if these column characteristics aren't available before execution. Elasticsearch/SQL doesn't support the concept of prepared statements. What the driver will now do if this mode is enabled (=the new default) is to execute the query right away, in case this lacks any parameters. In case the parameter marks are present, the early execution is disabled for the statement (and potentially the query will fail). However, most patterns of Elasticsearch/ODBC usage don't involve paramters and/or repeated executions. This change should allow more applications interop with Elasticsearch/SQL. (cherry picked from commit 5a1d4be)
This was referenced Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an early execution mode for prepared queries.
Applications generally prepare a statement, optionally reading result
set attributes - like columns count and their characteristics (types and
names) - before executing. A subset of these apps (generally the ones
following older API usage patterns) will fail the entire operation if
these column characteristics aren't available before execution.
Elasticsearch/SQL doesn't support the concept of prepared statements.
What the driver will now do if this mode is enabled (=the new default)
is to execute the query right away, in case this lacks any parameters.
In case the parameter marks are present, the early execution is disabled
for the statement (and potentially the query will fail). However, most
patterns of Elasticsearch/ODBC usage don't involve parameters and/or
repeated executions.
This change will allow more applications interop with
Elasticsearch/SQL.