Add two new config options to the DSN editor #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two new options to the configuration editor: - a numerical one, for the varchar limitation; - a boolean/tick one, for the early execution Some of the existing labels for the tick boxes have been updated to have the question marks removed.
codebrain
approved these changes
Apr 1, 2020
|
LGTM, the only thing is that it might be worth revisiting the documentation page here: https://www.elastic.co/guide/en/elasticsearch/reference/current/sql-odbc-setup.html with the additional parameters? |
bpintea
added a commit
that referenced
this pull request
Apr 2, 2020
This commit adds two new options to the configuration editor: - a numerical one, for the varchar limitation; - a boolean/tick one, for the early execution Some of the existing labels for the tick boxes have been updated to have the question marks removed. (cherry picked from commit d65ba95)
Thanks, I've opened elastic/elasticsearch#54632. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new options to the configuration editor:
Some of the existing texts for the checkboxes have been updated to have
the question marks removed.
Fixes #234.