Skip to content

Add two new config options to the DSN editor #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bpintea
Copy link
Collaborator

@bpintea bpintea commented Apr 1, 2020

This PR adds two new options to the configuration editor:

Some of the existing texts for the checkboxes have been updated to have
the question marks removed.

Fixes #234.

This commit adds two new options to the configuration editor:
- a numerical one, for the varchar limitation;
- a boolean/tick one, for the early execution

Some of the existing labels for the tick boxes have been updated to have
the question marks removed.
@codebrain
Copy link
Contributor

LGTM, the only thing is that it might be worth revisiting the documentation page here: https://www.elastic.co/guide/en/elasticsearch/reference/current/sql-odbc-setup.html with the additional parameters?

@bpintea bpintea merged commit d65ba95 into elastic:master Apr 2, 2020
@bpintea bpintea deleted the dsn/config_varcharlimit_early_execution branch April 2, 2020 09:55
bpintea added a commit that referenced this pull request Apr 2, 2020
This commit adds two new options to the configuration editor:
- a numerical one, for the varchar limitation;
- a boolean/tick one, for the early execution

Some of the existing labels for the tick boxes have been updated to have
the question marks removed.

(cherry picked from commit d65ba95)
@bpintea
Copy link
Collaborator Author

bpintea commented Apr 2, 2020

LGTM, the only thing is that it might be worth revisiting the documentation page here: https://www.elastic.co/guide/en/elasticsearch/reference/current/sql-odbc-setup.html with the additional parameters?

Thanks, I've opened elastic/elasticsearch#54632.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI: add support for the newly introduced early execution and varchar limit options
2 participants