Skip to content

[ML] Consolidate ExecutableActions for future expansion #110805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
prwhelan opened this issue Jul 11, 2024 · 1 comment
Closed

[ML] Consolidate ExecutableActions for future expansion #110805

prwhelan opened this issue Jul 11, 2024 · 1 comment
Assignees
@prwhelan
Labels
:ml Machine learning >non-issue Team:ML Meta label for the ML team

Comments

@prwhelan
Copy link
Member

Description

We are currently at ~17 ExecutableActions, each with common code. We can consolidate them into two different ExecutableActions. One will handle a single input (for Chat Completions), the other will handle many input (for all other task types).
@prwhelan prwhelan added >non-issue :ml Machine learning Team:ML Meta label for the ML team labels Jul 11, 2024
@prwhelan prwhelan self-assigned this Jul 11, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

prwhelan added a commit to prwhelan/elasticsearch that referenced this issue Jul 11, 2024
@prwhelan
[ML] Consolidate ExecutableActions
8ccd48b 
- Created two new ExecutableActions, SenderExecutableAction and
  SingleInputSenderExecutableAction
- Most chat completions are migrated over the
  SingleInputSenderExecutableAction
- Every other Action are migrated over to SenderExecutableAction
- RequestManagers and Error Message construction are migrated into the
  ActionCreator classes.

Relate elastic#110805
@prwhelan prwhelan mentioned this issue Jul 11, 2024
Merged
prwhelan added a commit that referenced this issue Jul 12, 2024
@prwhelan
[ML] Consolidate ExecutableActions (#110806)
7593db8 
- Created two new ExecutableActions, SenderExecutableAction and
  SingleInputSenderExecutableAction
- Most chat completions are migrated over the
  SingleInputSenderExecutableAction
- Every other Action are migrated over to SenderExecutableAction
- RequestManagers and Error Message construction are migrated into the
  ActionCreator classes.

Relate #110805
tvernum pushed a commit that referenced this issue Feb 25, 2025
@prwhelan @albertzaharovits
[ML] Consolidate ExecutableActions (#110806)
ed3efad 
- Created two new ExecutableActions, SenderExecutableAction and
  SingleInputSenderExecutableAction
- Most chat completions are migrated over the
  SingleInputSenderExecutableAction
- Every other Action are migrated over to SenderExecutableAction
- RequestManagers and Error Message construction are migrated into the
  ActionCreator classes.

Relate #110805
tvernum pushed a commit that referenced this issue Feb 25, 2025
@prwhelan @albertzaharovits
[ML] Consolidate ExecutableActions (#110806)
cc5d979 
- Created two new ExecutableActions, SenderExecutableAction and
  SingleInputSenderExecutableAction
- Most chat completions are migrated over the
  SingleInputSenderExecutableAction
- Every other Action are migrated over to SenderExecutableAction
- RequestManagers and Error Message construction are migrated into the
  ActionCreator classes.

Relate #110805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prwhelan prwhelan

Labels
:ml Machine learning >non-issue Team:ML Meta label for the ML team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prwhelan @elasticsearchmachine