Skip to content

[ML] Consolidate ExecutableActions #110806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2024
Merged

[ML] Consolidate ExecutableActions #110806

merged 1 commit into from
Jul 12, 2024

Conversation

prwhelan
Copy link
Member

  • Created two new ExecutableActions, SenderExecutableAction and SingleInputSenderExecutableAction
  • Most chat completions are migrated over the SingleInputSenderExecutableAction
  • Every other Action are migrated over to SenderExecutableAction
  • RequestManagers and Error Message construction are migrated into the ActionCreator classes.

Relate #110805

- Created two new ExecutableActions, SenderExecutableAction and
  SingleInputSenderExecutableAction
- Most chat completions are migrated over the
  SingleInputSenderExecutableAction
- Every other Action are migrated over to SenderExecutableAction
- RequestManagers and Error Message construction are migrated into the
  ActionCreator classes.

Relate elastic#110805
@prwhelan prwhelan added >non-issue :ml Machine learning Team:ML Meta label for the ML team labels Jul 11, 2024
@prwhelan prwhelan marked this pull request as ready for review July 11, 2024 23:49
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@prwhelan prwhelan merged commit 7593db8 into elastic:main Jul 12, 2024
15 checks passed
tvernum pushed a commit that referenced this pull request Feb 25, 2025
- Created two new ExecutableActions, SenderExecutableAction and
  SingleInputSenderExecutableAction
- Most chat completions are migrated over the
  SingleInputSenderExecutableAction
- Every other Action are migrated over to SenderExecutableAction
- RequestManagers and Error Message construction are migrated into the
  ActionCreator classes.

Relate #110805
tvernum pushed a commit that referenced this pull request Feb 25, 2025
- Created two new ExecutableActions, SenderExecutableAction and
  SingleInputSenderExecutableAction
- Most chat completions are migrated over the
  SingleInputSenderExecutableAction
- Every other Action are migrated over to SenderExecutableAction
- RequestManagers and Error Message construction are migrated into the
  ActionCreator classes.

Relate #110805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >non-issue Team:ML Meta label for the ML team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants