Skip to content

Migrate static backwards compatibility indices tests to qa:full-cluster-restart project #24939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
15 of 18 tasks
nik9000 opened this issue May 29, 2017 · 3 comments
Closed
15 of 18 tasks

Migrate static backwards compatibility indices tests to qa:full-cluster-restart project #24939

nik9000 opened this issue May 29, 2017 · 3 comments
Assignees
@nik9000
Labels
:Delivery/Build Build or test infrastructure Meta Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests

Comments

@nik9000
Copy link
Member

nik9000 commented May 29, 2017 •
edited by martijnvg
Loading

In #24846 we started migrating the static index backwards compatibility tests to a gradle project. We did this for a few reasons:

  1. The static tests played a lot of tricks to get everything to run in the same JVM so they weren't "real". This caused them to miss things from time to time. The qa:full-cluster-restart project has no such problems.
  2. It is more difficult to reason about the static backwards compatibility tests because the static indexes are just binary blobs built by a python script. We have to be careful to keep it up to date, etc. The indices built by qa:full-cluster-restart are built at testing time so any changes to the index building code apply immediately.
  3. Checking binary blobs into the code is icky.

There are a bunch of pieces left to port from the static tests to qa:full-cluster-restart:

There are a few things we need to clean up before we can remove a bunch of infrastructure for static bwc tests. I don't claim to know how to clean them all up:

And there are a bunch of things to add:
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests v6.0.0 labels May 29, 2017
@nik9000 nik9000 self-assigned this May 29, 2017
@martijnvg martijnvg mentioned this issue May 30, 2017
Merged
martijnvg added a commit to martijnvg/elasticsearch that referenced this issue May 31, 2017
@martijnvg
Move OldIndexBackwardsCompatibilityIT#assertBasicSearchWorks over to …
9531ef2 
…full cluster restart qa module.

Relates to elastic#24939
@martijnvg martijnvg mentioned this issue Jun 12, 2017
Merged
martijnvg added a commit to martijnvg/elasticsearch that referenced this issue Jun 15, 2017
@martijnvg
test: Ported more OldIndexBackwardsCompatibilityIT tests to full clus…
7b75b37 
…ter restart qa tests.

Relates to elastic#24939
martijnvg added a commit that referenced this issue Jun 15, 2017
@martijnvg
test: Ported more OldIndexBackwardsCompatibilityIT tests to full clus…
fe02829 
…ter restart qa tests. (#25173)

Relates to #24939
@martijnvg martijnvg mentioned this issue Jun 16, 2017
Merged
martijnvg added a commit to martijnvg/elasticsearch that referenced this issue Jun 19, 2017
@martijnvg
test: Port the remaining old indices search tests to full cluster res…
bcaa413 
…tart qa module

Also tweaked the qa module's gradle file to actually run bwc tests against all index compat versions.

Relates to elastic#24939
@nik9000
Copy link
Member Author

nik9000 commented Jun 19, 2017

@martijnvg I edited the issue description to add a few more things to clean up. I'm almost done with the snapshot/restore stuff and I'll open a PR for that soon.

@martijnvg martijnvg mentioned this issue Jun 22, 2017
Merged
martijnvg added a commit to martijnvg/elasticsearch that referenced this issue Jun 23, 2017
@martijnvg
test: Replace OldIndexBackwardsCompatibilityIT#testOldClusterStates w…
9c511bc 
…ith a full cluster restart qa test

OldIndexBackwardsCompatibilityIT#testOldClusterStates tested whether global and index metadata could be read from data directory,
 this can also be tested in full cluster qa test that checks cluster state via api.

 Relates to elastic#24939
@martijnvg martijnvg mentioned this issue Jul 14, 2017
Merged
martijnvg added a commit to martijnvg/elasticsearch that referenced this issue Jul 26, 2017
@martijnvg
test: Added a full cluster restart test for index shrinking
ff7c749 
Relates to elastic#24939
martijnvg added a commit that referenced this issue Jul 26, 2017
@martijnvg
test: Added a full cluster restart test for index shrinking
f31ada2 
Relates to #24939
martijnvg added a commit that referenced this issue Jul 26, 2017
@martijnvg
test: Added a full cluster restart test for index shrinking
54df81e 
Relates to #24939
@martijnvg martijnvg mentioned this issue Aug 9, 2017
Merged
martijnvg added a commit to martijnvg/elasticsearch that referenced this issue Aug 10, 2017
@martijnvg
Removed static indices and repos and the scripts that create them.
0e54603 
Two tests were still using the static indices:
* IndexFolderUpgraderTests#testUpgradeRealIndex()
* InternalEngineTests#testUpgradeOldIndex()

I removed these tests too, because these tests functionally overlap
with the full-cluster-restart qa tests.

Relates to elastic#24939
martijnvg added a commit that referenced this issue Aug 10, 2017
@martijnvg
Removed static indices and repos and the scripts that create them.
8185847 
Two tests were still using the static indices:
* IndexFolderUpgraderTests#testUpgradeRealIndex()
* InternalEngineTests#testUpgradeOldIndex()

I removed these tests too, because these tests functionally overlap
with the full-cluster-restart qa tests.

Relates to #24939
martijnvg added a commit that referenced this issue Aug 10, 2017
@martijnvg
Removed static indices and repos and the scripts that create them.
4744168 
Two tests were still using the static indices:
* IndexFolderUpgraderTests#testUpgradeRealIndex()
* InternalEngineTests#testUpgradeOldIndex()

I removed these tests too, because these tests functionally overlap
with the full-cluster-restart qa tests.

Relates to #24939
@nik9000 nik9000 removed the blocker label Oct 30, 2017
@lcawl lcawl added v6.0.1 and removed v6.0.0 labels Nov 13, 2017
@lcawl lcawl added v6.0.2 and removed v6.0.1 labels Dec 6, 2017
@jaymode jaymode added v6.0.3 and removed v6.0.2 labels Dec 13, 2017
@rjernst rjernst added the :Delivery/Build Build or test infrastructure label Apr 17, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@nik9000 nik9000 removed the v6.0.3 label Sep 23, 2018
@nik9000
Copy link
Member Author

nik9000 commented Sep 23, 2018

I believe we've migrated all of the remaining static bwc tests. A few month ago, actually. I just hadn't payed attention to this issue in the mean time.

@nik9000 nik9000 closed this as completed Sep 23, 2018
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
:Delivery/Build Build or test infrastructure Meta Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nik9000 @rjernst @mark-vieira @jaymode @elasticmachine @lcawl