Replace OldIndexBackwardsCompatibilityIT#testOldClusterStates with a full cluster restart qa test #25370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
review
>test
nik9000
approved these changes
Jun 22, 2017
| @@ -352,4 +352,10 @@ public boolean isCompatible(Version left, Version right) { | |||
| return result; | |||
| } | |||
|
|
|||
| private static final Version VERSION_5_1_0_UNRELEASED = Version.fromString("5.1.0"); | |||
There was a problem hiding this comment.
I don't think we need the constant.
| @@ -352,4 +352,10 @@ public boolean isCompatible(Version left, Version right) { | |||
| return result; | |||
| } | |||
|
|
|||
| private static final Version VERSION_5_1_0_UNRELEASED = Version.fromString("5.1.0"); | |||
|
|
|||
| public void testUnreleasedVersion() { | |||
There was a problem hiding this comment.
I know it didn't have a comment before but I imagine it'd be nice to add a comment now. Something like "This exists because 5.1.0 was never released due to a mistake in the release process. This verifies that we never declare the version as "released" accidentally. It would never pass qa tests later on, but those come very far in the build and this is quick to check now."
| } | ||
|
|
||
| public void testAllVersionsTested() throws Exception { | ||
| SortedSet<String> expectedVersions = new TreeSet<>(); |
There was a problem hiding this comment.
For posterity: this is handled by the gradle logic that scrapes the version file and a test in VersionUtilsTests that verifies that the gradle logic and VersionUtils line up.
…ith a full cluster restart qa test OldIndexBackwardsCompatibilityIT#testOldClusterStates tested whether global and index metadata could be read from data directory, this can also be tested in full cluster qa test that checks cluster state via api. Relates to elastic#24939
martijnvg
force-pushed
the
bwc_replace_testOldClusterStates_test
branch
from
d283ee5 to
9c511bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OldIndexBackwardsCompatibilityIT#testOldClusterStates tested whether global and index metadata could be read from data directory. I think this can also be tested in full cluster qa test that checks cluster state via cluster state api, this would also verify that the upgraded nodes were able to read the global and index state files successfully.
Relates to #24939