Skip to content

[DOCS] Re-enable code snippet testing for rollup APIs #33319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lcawl opened this issue Aug 31, 2018 · 2 comments
Closed

[DOCS] Re-enable code snippet testing for rollup APIs #33319

lcawl opened this issue Aug 31, 2018 · 2 comments
Assignees
@nik9000
Labels
>docs General docs changes :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data v6.3.3 v6.4.1 v6.5.0 v7.0.0-beta1

Comments

@lcawl
Copy link
Contributor

lcawl commented Aug 31, 2018

Related to #30665 and #31450

The code snippets in the rollup documentation was disabled because they ceased working after they were moved to the docs folder.

Per #31450 (comment), we need to move RollupRestTestStateCleaner over to the test framework and then use it in the docs tests.
@lcawl lcawl added >docs General docs changes v7.0.0 :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data :Docs v6.5.0 v6.3.3 v6.4.1 labels Aug 31, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@lcawl lcawl mentioned this issue Aug 31, 2018
Closed
5 tasks
@nik9000 nik9000 mentioned this issue Oct 6, 2018
Merged
@nik9000 nik9000 self-assigned this Oct 17, 2018
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Oct 17, 2018
@nik9000
Docs: Reenable rollup docs tests
ce46bdf 
We'd disabled them because we didn't have a way to clean up after each
test. I implemented elastic#34342 which adds the clean ups so now we can
re-enable the tests.

In the `setup` sections we have to use `raw` requests instead of
`x-pack` requests because we don't have the json config for x-pack.

Closes elastic#33319
@nik9000 nik9000 mentioned this issue Oct 17, 2018
Merged
nik9000 added a commit that referenced this issue Oct 18, 2018
@nik9000
Docs: Reenable rollup docs tests (#34564)
2c0f673 
We'd disabled them because we didn't have a way to clean up after each
test. I implemented #34342 which adds the clean ups so now we can
re-enable the tests.

In the `setup` sections we have to use `raw` requests instead of
`x-pack` requests because we don't have the json config for x-pack.

Closes #33319
nik9000 added a commit that referenced this issue Oct 19, 2018
@nik9000
Docs: Reenable rollup docs tests (#34564)
4030318 
We'd disabled them because we didn't have a way to clean up after each
test. I implemented #34342 which adds the clean ups so now we can
re-enable the tests.

In the `setup` sections we have to use `raw` requests instead of
`x-pack` requests because we don't have the json config for x-pack.

Closes #33319
kcm pushed a commit that referenced this issue Oct 30, 2018
@nik9000 @kcm
Docs: Reenable rollup docs tests (#34564)
a7a716f 
We'd disabled them because we didn't have a way to clean up after each
test. I implemented #34342 which adds the clean ups so now we can
re-enable the tests.

In the `setup` sections we have to use `raw` requests instead of
`x-pack` requests because we don't have the json config for x-pack.

Closes #33319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
>docs General docs changes :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data v6.3.3 v6.4.1 v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nik9000 @colings86 @elasticmachine @lcawl